NyanLinnPai/famous-ly4-ev
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

Revert "Make MarkBookingRefunded synchronous so refunds cancel instantly"

Browse Source 
This reverts commit 825320a117.
This commit is contained in:
Nyan Lin Paing
2026-09-03 10:56:55 +07:00
parent 825320a117
commit adabb2c690
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app-modules/payment/src/Listeners/MarkBookingRefunded.php
+6 -7
View File
@@ -2,6 +2,7 @@
namespace Modules\Payment\Listeners; namespace Modules\Payment\Listeners;
use Illuminate\Contracts\Queue\ShouldQueue;
use Modules\Booking\Enums\BookingStatus; use Modules\Booking\Enums\BookingStatus;
use Modules\Payment\Events\RefundProcessed; use Modules\Payment\Events\RefundProcessed;
@@ -10,14 +11,8 @@ use Modules\Payment\Events\RefundProcessed;
* completes (domain.md §5). Guarded the same way as MarkBookingPaid — only * completes (domain.md §5). Guarded the same way as MarkBookingPaid — only
* ever moves a still-confirmed booking, never clobbers one that moved on * ever moves a still-confirmed booking, never clobbers one that moved on
* for another reason. * for another reason.
*
* Deliberately synchronous, unlike MarkBookingPaid — a refund is always
* initiated from a request that's already waiting on it (the Filament
* action or the API endpoint), and staff expect the booking's status to
* read Cancelled the instant that request completes, not once a queue
* worker gets to it.
*/ */
class MarkBookingRefunded class MarkBookingRefunded implements ShouldQueue
{ {
public function handle(RefundProcessed $event): void public function handle(RefundProcessed $event): void
{ {
@@ -27,6 +22,10 @@ class MarkBookingRefunded
// pre-redesign rows where booking_id wasn't yet recorded. // pre-redesign rows where booking_id wasn't yet recorded.
$booking = $event->refund->booking ?? $event->refund->payment->booking; $booking = $event->refund->booking ?? $event->refund->payment->booking;
// Booking uses SoftDeletes — normally unreachable here (a confirmed
// booking is never deletable, BookingPolicy::delete), but this
// listener is queued, so it's worth guarding against a booking that
// vanished between dispatch and execution regardless.
if ($booking === null) { if ($booking === null) {
return; return;
} }
app-modules/payment/tests/Feature/MarkBookingRefundedTest.php
+1 -1
View File
@@ -29,7 +29,7 @@ test('does not touch a booking that already moved on for another reason', functi
expect($booking->refresh()->status)->toBe(BookingStatus::Cancelled); expect($booking->refresh()->status)->toBe(BookingStatus::Cancelled);
}); });
test('does not crash if the booking was soft-deleted before this listener ran', function () { test('does not crash if the booking was soft-deleted before this queued listener ran', function () {
$booking = Booking::factory()->create(['status' => BookingStatus::Confirmed]); $booking = Booking::factory()->create(['status' => BookingStatus::Confirmed]);
$payment = Payment::factory()->completed()->create(['booking_id' => $booking->id, 'gateway' => PaymentMethod::KbzMiniApp]); $payment = Payment::factory()->completed()->create(['booking_id' => $booking->id, 'gateway' => PaymentMethod::KbzMiniApp]);
$refund = Refund::factory()->create(['payment_id' => $payment->id, 'status' => RefundStatus::Completed]); $refund = Refund::factory()->create(['payment_id' => $payment->id, 'status' => RefundStatus::Completed]);