NyanLinnPai/famous-ly4-ev
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Generalize per-vehicle-option booking rules to Front Seat too

Browse Source 
Front Seat previously had a hardcoded max-per-booking check with no enable
toggle; now every Vehicle Option (front_seat/back_seat/whole_vehicle) gets
the same config-driven pair — an on/off toggle and a max passenger_count —
surfaced via new BOOKING_*_ENABLED/BOOKING_*_MAX_PER_BOOKING env vars,
editable from ManageAppSettings, and exposed on route pricing as
max_per_booking.
This commit is contained in:
Nyan Lin Paing
2026-08-30 15:45:27 +07:00
parent 914b7f97f3
commit bebcab88fa
11 changed files with 175 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app-modules/booking/src/Exceptions/InvalidVehicleSelectionException.php
+2 -2
View File
@@ -9,9 +9,9 @@ use RuntimeException;
class InvalidVehicleSelectionException extends RuntimeException
{
public static function frontSeatLimitExceeded(int $requested, int $max): self
public static function passengerLimitExceeded(VehicleOption $vehicleOption, int $requested, int $max): self
{
return new self("Front seat request [{$requested}] exceeds the max of [{$max}] per booking.");
return new self("Vehicle option [{$vehicleOption->value}] passenger count [{$requested}] exceeds the max of [{$max}] per booking.");
}
public static function optionDisabled(VehicleOption $vehicleOption): self
app-modules/booking/src/Services/BookingService.php
+18 -21
View File
@@ -9,11 +9,11 @@ use Modules\Shared\Enums\VehicleOption;
class BookingService
{
/**
* Enforces the only v1 inventory rule (max Front Seats per booking), the
* blunt config toggles for Back Seat / Whole Vehicle availability, and
* shape rules around combining options in one booking (no duplicate
* option lines, Whole Vehicle can't be mixed with anything else since it
* already covers the whole car).
* Enforces the same two blunt, config-driven rules for every Vehicle
* Option — an on/off toggle and a max passenger_count per booking (see
* domain.md §2) — plus shape rules around combining options in one
* booking (no duplicate option lines, Whole Vehicle can't be mixed with
* anything else since it already covers the whole car).
*
* Deliberately does not check real capacity/availability — that's an
* explicitly deferred future phase (domain.md §2, §7).
@@ -43,26 +43,23 @@ class BookingService
private function validateOption(VehicleOption $vehicleOption, int $passengerCount): void
{
match ($vehicleOption) {
VehicleOption::FrontSeat => $this->validateFrontSeat($passengerCount),
VehicleOption::BackSeat => $this->validateEnabled($vehicleOption, 'booking.back_seat_enabled'),
VehicleOption::WholeVehicle => $this->validateEnabled($vehicleOption, 'booking.whole_vehicle_enabled'),
};
$this->validateEnabled($vehicleOption);
$this->validateMax($vehicleOption, $passengerCount);
}
private function validateFrontSeat(int $passengerCount): void
private function validateEnabled(VehicleOption $vehicleOption): void
{
$max = config('booking.front_seat_max_per_booking');
if ($passengerCount > $max) {
throw InvalidVehicleSelectionException::frontSeatLimitExceeded($passengerCount, $max);
}
}
private function validateEnabled(VehicleOption $vehicleOption, string $configKey): void
{
if (! config($configKey)) {
if (! config("booking.{$vehicleOption->value}_enabled")) {
throw InvalidVehicleSelectionException::optionDisabled($vehicleOption);
}
}
private function validateMax(VehicleOption $vehicleOption, int $passengerCount): void
{
$max = config("booking.{$vehicleOption->value}_max_per_booking");
if ($passengerCount > $max) {
throw InvalidVehicleSelectionException::passengerLimitExceeded($vehicleOption, $passengerCount, $max);
}
}
}