NyanLinnPai/famous-ly4-ev
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chg sync endpoint
PHP Tests / php-tests (push) Waiting to run
Details

Browse Source
This commit is contained in:
Nyan Lin Paing
2026-09-03 00:33:10 +07:00
parent d1ce73e7ff
commit 3768b82932
4 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app-modules/shared/src/Bnfexpress/BnfexpressAdminClient.php
+4 -4
View File
@@ -282,7 +282,7 @@ class BnfexpressAdminClient
*/
public function syncSuggestions(): array
{
return $this->request('POST', '/admin/suggestions/sync-chroma');
return $this->request('POST', '/admin/suggestions/sync');
}
/**
@@ -290,7 +290,7 @@ class BnfexpressAdminClient
*/
public function getSuggestionSyncStatus(string $jobId): array
{
return $this->request('GET', "/admin/suggestions/sync-chroma/{$jobId}");
return $this->request('GET', "/admin/suggestions/sync/{$jobId}");
}
/**
@@ -298,7 +298,7 @@ class BnfexpressAdminClient
*/
public function syncOneSuggestion(int|string $id): array
{
return $this->request('POST', "/admin/suggestions/{$id}/sync-chroma");
return $this->request('POST', "/admin/suggestions/{$id}/sync");
}
/**
@@ -314,7 +314,7 @@ class BnfexpressAdminClient
*/
public function deleteSuggestionEmbedding(int|string $id): array
{
return $this->request('DELETE', "/admin/suggestions/{$id}/chroma");
return $this->request('DELETE', "/admin/suggestions/{$id}/embedding");
}
// --- Request plumbing ------------------------------------------------
app-modules/shared/tests/Unit/BnfexpressAdminClientTest.php
+5 -5
View File
@@ -175,13 +175,13 @@ test('promoteSuggestionMisses posts miss_ids with an optional lang/intent overri
&& $request->body() === json_encode(['miss_ids' => [1, 2], 'lang' => 'my']));
});
test('syncSuggestions triggers a sync-chroma job and returns the job id', function () use ($config) {
test('syncSuggestions triggers a sync job and returns the job id', function () use ($config) {
Http::fake(['bnfexpress.test/*' => Http::response(['job_id' => 'abc-123'], 202)]);
$result = (new BnfexpressAdminClient($config))->syncSuggestions();
expect($result)->toBe(['job_id' => 'abc-123']);
Http::assertSent(fn ($request) => $request->url() === 'https://bnfexpress.test/admin/suggestions/sync-chroma'
Http::assertSent(fn ($request) => $request->url() === 'https://bnfexpress.test/admin/suggestions/sync'
&& $request->method() === 'POST');
});
@@ -191,7 +191,7 @@ test('getSuggestionSyncStatus polls the job status endpoint', function () use ($
$result = (new BnfexpressAdminClient($config))->getSuggestionSyncStatus('abc-123');
expect($result)->toBe(['status' => 'finished', 'result' => ['synced' => 3]]);
Http::assertSent(fn ($request) => $request->url() === 'https://bnfexpress.test/admin/suggestions/sync-chroma/abc-123'
Http::assertSent(fn ($request) => $request->url() === 'https://bnfexpress.test/admin/suggestions/sync/abc-123'
&& $request->method() === 'GET');
});
@@ -201,8 +201,8 @@ test('deleteSuggestionEmbedding signs a bodyless DELETE request', function () us
(new BnfexpressAdminClient($config))->deleteSuggestionEmbedding(5);
Http::assertSent(function ($request) use ($config) {
return $request->url() === 'https://bnfexpress.test/admin/suggestions/5/chroma'
return $request->url() === 'https://bnfexpress.test/admin/suggestions/5/embedding'
&& $request->method() === 'DELETE'
&& assertSignedCorrectly($request, 'DELETE', '/admin/suggestions/5/chroma', '', $config['client_secret']);
&& assertSignedCorrectly($request, 'DELETE', '/admin/suggestions/5/embedding', '', $config['client_secret']);
});
});